fix(next): don't log a phantom error for redirect()/notFound() signals by HugoRCD · Pull Request #438 · HugoRCD/evlog

HugoRCD · 2026-07-22T09:03:31Z

Closes #436

withEvlog treats Next.js control-flow signals thrown by redirect(), notFound(), forbidden(), and unauthorized() as real application errors: the catch block always called logger.error() and defaulted the status to 500 (these signals carry their real status in error.digest, not .status/.statusCode), leaving a phantom ERROR@500 wide event for every redirect/404.

Fix

Detect the signal before logging, using Next's own unstable_rethrow (from next/navigation) so it covers current and future signal types without hardcoding digest strings. If recognized, rethrow untouched — no logging, no emitted event. Otherwise, fall through to the existing error-logging path unchanged.

Testing

Added 3 regression tests in test/next/handler.test.ts: redirect() signal, notFound() signal, and a real error whose message happens to mention NEXT_REDIRECT (to confirm we only skip logging based on digest, not message content).
Full suite (pnpm run test), pnpm run lint, pnpm run typecheck, and pnpm run build:package all pass.
pnpm api:snapshot — no public API changes.

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where Next.js control-flow helpers (redirect(), notFound(), and related responses) could be incorrectly recorded as HTTP 500 errors.
- Navigation signal errors are now rethrown correctly, preventing phantom logging/output and avoiding draining for these non-error execution paths.
- Improved handling when navigation signals are wrapped via error.cause, ensuring the underlying signal is rethrown without triggering error logging.
- Genuine application errors still log normally, even if their message mentions Next.js redirect signals without the expected digest.

vercel · 2026-07-22T09:03:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
evlog-docs	Ready	Preview, Comment, Open in v0	Jul 22, 2026 9:21am
just-use-evlog	Ready	Preview, Comment	Jul 22, 2026 9:21am

github-actions · 2026-07-22T09:03:40Z

Thank you for following the naming conventions! 🙏

coderabbitai · 2026-07-22T09:05:40Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eb9db3f4-454d-413b-a808-d11f11b55b6f

📥 Commits

Reviewing files that changed from the base of the PR and between fd5eb78 and 9399154.

📒 Files selected for processing (2)

packages/evlog/src/next/handler.ts
packages/evlog/test/next/handler.test.ts

📝 Walkthrough

Walkthrough

withEvlog now detects Next.js navigation control-flow signals and rethrows them before error logging. Tests verify suppressed logging for valid signals and normal HTTP 500 handling for ordinary errors.

Changes

Next.js navigation signal handling

Layer / File(s)	Summary
Detect and rethrow control-flow signals `packages/evlog/src/next/handler.ts`	Dynamically checks for Next.js `unstable_rethrow` and invokes it before the wrapper’s normal error conversion and logging path.
Validate signal and error handling `packages/evlog/test/next/handler.test.ts`, `.changeset/fix-next-navigation-signal-phantom-error.md`	Tests valid and wrapped navigation signals for identity preservation and suppressed logging, while confirming signal-like ordinary errors remain logged at status 500; documents the patch.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

HugoRCD/evlog#381: Both changes modify the Next.js handler’s error-processing path.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise, conventional, and accurately summarizes the Next.js phantom error fix.
Description check	✅ Passed	The description covers the issue, fix, and testing, though the checklist boxes are not filled in.
Linked Issues check	✅ Passed	The change satisfies `#436` by rethrowing Next.js control-flow signals without logging phantom ERROR@500 events.
Out of Scope Changes check	✅ Passed	The added tests and changeset are directly related to the Next.js logging fix, with no unrelated code changes evident.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/next-navigation-signal-phantom-error

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-07-22T09:06:40Z

npm i https://pkg.pr.new/evlog@438

npm i https://pkg.pr.new/@evlog/nuxthub@438

npm i https://pkg.pr.new/@evlog/telemetry@438

commit: fd5eb78

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/evlog/src/next/handler.ts`:
- Around line 129-139: Update isNextNavigationSignal to separate the
next/navigation import failure from invoking unstable_rethrow, type
unstable_rethrow as returning void, and return false only when the import or
function availability check fails. Invoke unstable_rethrow outside the import
catch so its thrown unwrapped redirect/not-found signal propagates directly
instead of comparing thrown === error.

In `@packages/evlog/test/next/handler.test.ts`:
- Around line 134-188: Add tests alongside the existing redirect() and
notFound() cases for forbidden() and unauthorized() navigation signals, using
digests NEXT_HTTP_ERROR_FALLBACK;403 and NEXT_HTTP_ERROR_FALLBACK;401
respectively. For each handler, assert the original error is rethrown by
identity and that consoleErrorSpy, consoleSpy, and the drain mock are not
called.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2aa19683-f75e-4c71-bd4a-55bf5ba5ffaf

📥 Commits

Reviewing files that changed from the base of the PR and between 30ccb08 and fd5eb78.

📒 Files selected for processing (3)

.changeset/fix-next-navigation-signal-phantom-error.md
packages/evlog/src/next/handler.ts
packages/evlog/test/next/handler.test.ts

fix(next): don't log a phantom error for redirect()/notFound() signals

fd5eb78

github-actions Bot added the bug Something isn't working label Jul 22, 2026

vercel Bot deployed to Preview – just-use-evlog July 22, 2026 09:04 View deployment

vercel Bot deployed to Preview – evlog-docs July 22, 2026 09:07 View deployment

coderabbitai Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread packages/evlog/src/next/handler.ts Outdated

Comment thread packages/evlog/test/next/handler.test.ts

fix(next): let unstable_rethrow propagate wrapped navigation signals

9399154

vercel Bot deployed to Preview – just-use-evlog July 22, 2026 09:18 View deployment

HugoRCD merged commit 51c5752 into main Jul 22, 2026
13 of 15 checks passed

HugoRCD deleted the fix/next-navigation-signal-phantom-error branch July 22, 2026 09:20

github-actions Bot mentioned this pull request Jul 22, 2026

chore(repo): version packages #439

Merged

vercel Bot deployed to Preview – evlog-docs July 22, 2026 09:21 View deployment

github-actions Bot mentioned this pull request Jul 22, 2026

chore(repo): version packages #440

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(next): don't log a phantom error for redirect()/notFound() signals#438

fix(next): don't log a phantom error for redirect()/notFound() signals#438
HugoRCD merged 2 commits into
mainfrom
fix/next-navigation-signal-phantom-error

HugoRCD commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

HugoRCD commented Jul 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix

Testing

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

HugoRCD commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading